Skip to content

8211822: Some tests fail after JDK-8210039 #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 11, 2022

A test fix. Had to adapt ProblemList, rest applies clean.
Marking as /clean


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8211822: Some tests fail after JDK-8210039
  • JDK-8202886: [macos] Test java/awt/MenuBar/8007006/bug8007006.java fails on MacOS

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/882/head:pull/882
$ git checkout pull/882

Update a local copy of the PR:
$ git checkout pull/882
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/882/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 882

View PR using the GUI difftool:
$ git pr show -t 882

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/882.diff

@GoeLin GoeLin changed the base branch from master to pr/876 March 11, 2022 14:45
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/876 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin
Copy link
Member Author

GoeLin commented Mar 11, 2022

/clean

@openjdk
Copy link

openjdk bot commented Mar 11, 2022

@GoeLin Can only mark backport pull requests, with an original hash, as clean

@GoeLin GoeLin changed the title Goetz backport 8211822 Goetz backport 245a72938ada2914d5c81a0044c8a09696244214 Mar 11, 2022
@GoeLin GoeLin changed the title Goetz backport 245a72938ada2914d5c81a0044c8a09696244214 Backport 245a72938ada2914d5c81a0044c8a09696244214 Mar 11, 2022
@openjdk openjdk bot changed the title Backport 245a72938ada2914d5c81a0044c8a09696244214 8211822: Some tests fail after JDK-8210039 Mar 11, 2022
@openjdk
Copy link

openjdk bot commented Mar 11, 2022

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 11, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Mar 14, 2022

Pre-submit failures:
crash in gc/cms/TestBubbleUpRef.java
dependencies missing.
both unrelated.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/876 to master March 14, 2022 07:48
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8210039
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211822: Some tests fail after JDK-8210039
8202886: [macos] Test java/awt/MenuBar/8007006/bug8007006.java fails on MacOS

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 14, 2022
@GoeLin GoeLin changed the base branch from master to pr/856 March 14, 2022 07:50
@GoeLin GoeLin changed the base branch from pr/856 to master March 14, 2022 07:51
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

⚠️ @GoeLin This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Mar 14, 2022
@GoeLin GoeLin force-pushed the goetz_backport_8211822 branch from d667595 to 8b7e555 Compare March 14, 2022 07:54
@GoeLin
Copy link
Member Author

GoeLin commented Mar 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

Going to push as commit 2ed46d8.
Since your change was applied there have been 3 commits pushed to the master branch:

  • f441970: 8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget())
  • f3708bb: 8225475: Node budget asserts on x86_32/64
  • 997c55f: 8283018: 11u GHA: Update GCC 9 minor versions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 14, 2022
@openjdk openjdk bot closed this Mar 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@GoeLin Pushed as commit 2ed46d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8211822 branch March 14, 2022 14:06
@GoeLin GoeLin restored the goetz_backport_8211822 branch March 15, 2022 09:52
@GoeLin GoeLin deleted the goetz_backport_8211822 branch April 1, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants