Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget()) #884

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 11, 2022

Backport of trivial Shenandoah fix JDK-8223389 after JDK-8223502 and JDK-8216137 were backported.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget())

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/884/head:pull/884
$ git checkout pull/884

Update a local copy of the PR:
$ git checkout pull/884
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/884/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 884

View PR using the GUI difftool:
$ git pr show -t 884

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/884.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8b07b191c3a8f01085bcf9baf677fb0699183c05 8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget()) Mar 11, 2022
@openjdk
Copy link

openjdk bot commented Mar 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 11, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget())

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 11, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 11, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Mar 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 14, 2022

Going to push as commit f441970.
Since your change was applied there have been 3 commits pushed to the master branch:

  • f3708bb: 8225475: Node budget asserts on x86_32/64
  • 997c55f: 8283018: 11u GHA: Update GCC 9 minor versions
  • c94ce2c: 8210039: move OSInfo to top level testlibrary

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 14, 2022
@openjdk openjdk bot closed this Mar 14, 2022
@openjdk openjdk bot removed ready rfr labels Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

@TheRealMDoerr Pushed as commit f441970.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8223389_C2_Shenandoah branch Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant