Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport cebaad1c94c301304fd146526cac95bfeaac66bf #886

Closed
wants to merge 2 commits into from

Conversation

rkennke
Copy link
Contributor

@rkennke rkennke commented Mar 14, 2022

This backports the fix for JDK-8280041, which fixes a number of small issues with the preceding change for JDK-8277072.
The original change has baked for several weeks in jdk19 and applies cleanly.

Testing:

  • tier1
  • tier2
  • tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278065: Refactor subclassAudits to use ClassValue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/886/head:pull/886
$ git checkout pull/886

Update a local copy of the PR:
$ git checkout pull/886
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/886/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 886

View PR using the GUI difftool:
$ git pr show -t 886

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/886.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2022

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@rkennke rkennke changed the title Backport 8278065 Backport cebaad1c94c301304fd146526cac95bfeaac66bf Mar 14, 2022
@openjdk openjdk bot changed the title Backport cebaad1c94c301304fd146526cac95bfeaac66bf 8278065: Refactor subclassAudits to use ClassValue Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

@openjdk openjdk bot added backport rfr labels Mar 14, 2022
@rkennke rkennke changed the title 8278065: Refactor subclassAudits to use ClassValue Backport cebaad1c94c301304fd146526cac95bfeaac66bf Mar 14, 2022
@rkennke rkennke closed this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr
1 participant