Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8229499: Node budget assert in fuzzed test #888

Closed
wants to merge 1 commit into from
Closed

8229499: Node budget assert in fuzzed test #888

wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 14, 2022

Almost clean backport of JDK-8229499
Only the minor cleanup in loopnode.hpp required manual integration.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/888/head:pull/888
$ git checkout pull/888

Update a local copy of the PR:
$ git checkout pull/888
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/888/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 888

View PR using the GUI difftool:
$ git pr show -t 888

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/888.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8275b17b07b1c15bde79b36b76ecbe3072db1e1a 8229499: Node budget assert in fuzzed test Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 14, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2022

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my non-JIT eyes. loopnode.hpp looks fine (was hard to spot the one relevant chance in the many cleanups).

Cheers, Thomas

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8229499: Node budget assert in fuzzed test

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • ed275ba: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
  • 2ed46d8: 8211822: Some tests fail after JDK-8210039

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 15, 2022
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!

@GoeLin
Copy link
Member

GoeLin commented Mar 15, 2022

Pre-submit tests gc/cms/TestBubbleUpRef.java timed out
I saw problem with this test in other Pre-submit runs, so this should be unrelated.

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

Going to push as commit 18b5f5b.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 6c84ce9: 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101"
  • ed275ba: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
  • 2ed46d8: 8211822: Some tests fail after JDK-8210039

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 15, 2022
@openjdk openjdk bot closed this Mar 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@TheRealMDoerr Pushed as commit 18b5f5b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants