Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes #89

Closed

Conversation

jianglizhou
Copy link
Contributor

@jianglizhou jianglizhou commented Jun 30, 2021

Please review the backport of JDK-8230674. Backport was created with the /backport commit command. Original patch applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/89/head:pull/89
$ git checkout pull/89

Update a local copy of the PR:
$ git checkout pull/89
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/89/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 89

View PR using the GUI difftool:
$ git pr show -t 89

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/89.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 30, 2021

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e90970b67bb3cd1980ac873b0c9465e53f494e37 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes Jun 30, 2021
@openjdk
Copy link

openjdk bot commented Jun 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@jianglizhou This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 05c7697: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 37bc75b: 8241768: git needs .gitattributes
  • 351cb48: 8225583: Examine the HttpResponse.BodySubscribers for null handling and multiple subscriptions
  • 8ae2846: 8232243: Wrong caret position in JTextPane on Windows with a screen resolution > 100%
  • a2af649: 8268775: Password is being converted to String in AccessibleJPasswordField
  • 7639f8c: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 0e2d915: 8257620: Do not use objc_msgSend_stret to get macOS version
  • 6e60332: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV
  • ... and 92 more: https://git.openjdk.java.net/jdk11u-dev/compare/0e4fdcf11ad65d2515a78e30eb9f3d81451004b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 30, 2021

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@RealCLanger
Copy link
Contributor

@jianglizhou, will you integrate this one any time soon? 😃

@jianglizhou
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 3, 2021

Going to push as commit aebdee3.
Since your change was applied there have been 102 commits pushed to the master branch:

  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 05c7697: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 37bc75b: 8241768: git needs .gitattributes
  • 351cb48: 8225583: Examine the HttpResponse.BodySubscribers for null handling and multiple subscriptions
  • 8ae2846: 8232243: Wrong caret position in JTextPane on Windows with a screen resolution > 100%
  • a2af649: 8268775: Password is being converted to String in AccessibleJPasswordField
  • 7639f8c: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 0e2d915: 8257620: Do not use objc_msgSend_stret to get macOS version
  • 6e60332: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV
  • ... and 92 more: https://git.openjdk.java.net/jdk11u-dev/compare/0e4fdcf11ad65d2515a78e30eb9f3d81451004b8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 3, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 3, 2021
@openjdk
Copy link

openjdk bot commented Aug 3, 2021

@jianglizhou Pushed as commit aebdee3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jianglizhou
Copy link
Contributor Author

@RealCLanger, integrated 😃

@RealCLanger
Copy link
Contributor

@RealCLanger, integrated 😃

Cool, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants