Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231565: More node budget asserts in fuzzed tests #890

Closed
wants to merge 2 commits into from
Closed

8231565: More node budget asserts in fuzzed tests #890

wants to merge 2 commits into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 14, 2022

Almost clean backport of https://bugs.openjdk.java.net/browse/JDK-8231565
Only cleanup in PhaseIdealLoop::partial_peel (loopopts.cpp) required manual integration.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8231565: More node budget asserts in fuzzed tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/890/head:pull/890
$ git checkout pull/890

Update a local copy of the PR:
$ git checkout pull/890
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/890/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 890

View PR using the GUI difftool:
$ git pr show -t 890

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/890.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 14, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into pr/888 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 902858e3ceb43bf92ea9fa038b9edcf1ee0c48b5 8231565: More node budget asserts in fuzzed tests Mar 14, 2022
@openjdk
Copy link

openjdk bot commented Mar 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Mar 14, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 14, 2022

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/888 to master March 15, 2022 10:22
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8229499_C2_node_budget
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Mar 15, 2022
@TheRealMDoerr
Copy link
Contributor Author

Looks messed up. I'll recreate it.

@TheRealMDoerr TheRealMDoerr deleted the 8231565_C2_node_budget branch March 15, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant