Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8231565: More node budget asserts in fuzzed tests #893

Closed
wants to merge 1 commit into from
Closed

8231565: More node budget asserts in fuzzed tests #893

wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 15, 2022

Basically clean backport of https://bugs.openjdk.java.net/browse/JDK-8231565
Only cleanup in PhaseIdealLoop::partial_peel (loopopts.cpp) required manual integration, but looks identical.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8231565: More node budget asserts in fuzzed tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/893/head:pull/893
$ git checkout pull/893

Update a local copy of the PR:
$ git checkout pull/893
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/893/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 893

View PR using the GUI difftool:
$ git pr show -t 893

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/893.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 15, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 902858e3ceb43bf92ea9fa038b9edcf1ee0c48b5 8231565: More node budget asserts in fuzzed tests Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8231565: More node budget asserts in fuzzed tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2022
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

Going to push as commit f8abb70.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 15, 2022
@openjdk openjdk bot closed this Mar 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@TheRealMDoerr Pushed as commit f8abb70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8231565_C2_node_budget_2 branch March 15, 2022 11:00
@mlbridge
Copy link

mlbridge bot commented Mar 15, 2022

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant