-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8278065: Refactor subclassAudits to use ClassValue #899
Conversation
👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@RogerRiggs @plevart If you find some time, could you please review this backport? Thank you! |
Pre-submit failures; gcc issues, unrelated. |
Looks good. |
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout rkennke-backport-8eb453ba
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@rkennke this pull request can not be integrated into git checkout backport-JDK-8278065
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@rkennke This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
This backports the fix for JDK-8278065, which fixes a number of small issues with the preceding change for JDK-8277072.
The original change has baked for several weeks in jdk19 and applies with some conflicts caused by different context.
Testing:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/899/head:pull/899
$ git checkout pull/899
Update a local copy of the PR:
$ git checkout pull/899
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/899/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 899
View PR using the GUI difftool:
$ git pr show -t 899
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/899.diff