Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp #901

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 16, 2022

I would like to backport this patch to 11u for reducing noise on JDK-8231111.

The original patch does not apply cleanly, due to out-of-order backport of JDK-8202142.

Test:

  • jdk_jfr
    EvilInstrument.java test fails. Followup JDK-8230865 backport to fix it.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/901/head:pull/901
$ git checkout pull/901

Update a local copy of the PR:
$ git checkout pull/901
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/901/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 901

View PR using the GUI difftool:
$ git pr show -t 901

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/901.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7d3aebccc0b90aa2ca2f656c683fa5931fd0ed3a 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp Mar 16, 2022
@openjdk
Copy link

openjdk bot commented Mar 16, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added the backport label Mar 16, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 16, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2022

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

LGTM.

@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp

Using test utils to create temp files and directories

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 16, 2022
@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Mar 17, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

Going to push as commit 6135540.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 9543488: 8247592: refactor test/jdk/tools/launcher/Test7029048.java
  • 62afe2e: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28
  • e1b2f92: 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist!
  • 38e44eb: 8199874: [TESTBUG] runtime/Thread/ThreadPriorities.java fails with "expected 0 to equal 10"
  • ebf6a5b: 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2022
@openjdk openjdk bot closed this Mar 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@zhengyu123 Pushed as commit 6135540.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants