-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target #903
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue and summary from the original commit. |
Webrevs
|
/integrate |
@zhengyu123 This pull request has not yet been marked as ready for integration. |
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout backport-8223396-jfr-test
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@zhengyu123 Please follow the steps in comment #903 (comment) so as to make this a clean backport again. Then integration should work. |
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 23af0b1.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit 23af0b1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I would like to backport this patch to fix test failure, introduced by JDK-8223396.
This is a clean backport on top of JDK-8223396 backport.
Test:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/903/head:pull/903
$ git checkout pull/903
Update a local copy of the PR:
$ git checkout pull/903
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/903/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 903
View PR using the GUI difftool:
$ git pr show -t 903
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/903.diff