8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

[AlexanderScherbatiy]

This is the request to backport the fix to jdk11u.

The original patch https://github.com/openjdk/jdk/commit/02287349.patch
has only one conflict with copyright year (2018 vs 2015) in src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java file comparing with jdk11u-dev repository.

WPrinterJob.java in JDK-8262470 patch: WPrinterJob.java#L2

WPrinterJob.java in jdk11u-dev repo:
https://github.com/openjdk/jdk11u-dev/blob/master/src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java#L2

The java/awt/print and java/awt/PrintJob automated and manual tests were run with the fix.

The automated tests pass.
The following manual tests fail with and without the fix:

Parse Exception: Arguments to manual option not supported: yesno:
java/awt/print/Dialog/DialogOrient.java Error. Parse Exception: Arguments to manual' option not supported: yesno java/awt/print/Dialog/DialogType.java Error. Parse Exception: Arguments to manual' option not supported: yesno
java/awt/print/PrinterJob/ImagePrinting/ClippedImages.java Error. Parse Exception: Arguments to manual' option not supported: yesno java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java Error. Parse Exception: Arguments to manual' option not supported: yesno
java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java Error. Parse Exception: Arguments to manual' option not supported: yesno java/awt/print/PrinterJob/PageDialogTest.java Error. Parse Exception: Arguments to manual' option not supported: yesno
java/awt/print/PrinterJob/PageRanges.java Error. Parse Exception: Arguments to manual' option not supported: yesno java/awt/print/PrinterJob/PageRangesDlgTest.java Error. Parse Exception: Arguments to manual' option not supported: yesno
java/awt/print/PrinterJob/PrintGlyphVectorTest.java Error. Parse Exception: Arguments to manual' option not supported: yesno java/awt/print/PrinterJob/PrintLatinCJKTest.java Error. Parse Exception: Arguments to manual' option not supported: yesno
java/awt/print/PrinterJob/PrintTextTest.java Error. Parse Exception: Arguments to manual' option not supported: yesno java/awt/print/PrinterJob/SwingUIText.java Error. Parse Exception: Arguments to manual' option not supported: yesno
java/awt/PrintJob/ConstrainedPrintingTest/ConstrainedPrintingTest.java Error. Parse Exception: Arguments to manual' option not supported: yesno java/awt/PrintJob/PageSetupDlgBlockingTest/PageSetupDlgBlockingTest.java Error. Parse Exception: Arguments to manual' option not supported: yesno
java/awt/PrintJob/SaveDialogTitleTest.java Error. Parse Exception: Arguments to `manual' option not supported: yesno

Cannot access a member of class:
java/awt/print/Dialog/PrintDlgApp.java Error. java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainThread cannot access a member of class PrintDlgApp with modifiers "public static"
java/awt/print/Dialog/PrintDlgPageable.java Error. java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainThread cannot access a member of class PrintDlgPageable with modifiers "public static"

Can't find HTML file:
java/awt/PrintJob/PrintCheckboxTest/PrintCheckboxManualTest.java Error. Can't find HTML file: C:\Development\github\alexsch\jdk11u-dev-print\test\jdk\java\awt\PrintJob\PrintCheckboxTest\PrintCheckboxManualTest.html

Does not have buttons on test dialog (pass, fail, ...)
java/awt/print/PrinterJob/SecurityDialogTest.java

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/91/head:pull/91
$ git checkout pull/91

Update a local copy of the PR:
$ git checkout pull/91
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/91/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 91

View PR using the GUI difftool:
$ git pr show -t 91

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/91.diff

[bridgekeeper]

👋 Welcome back alexsch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (1a0b1ba2)

[RealCLanger]

LGTM

[openjdk]

@AlexanderScherbatiy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8262470: Printed GlyphVector outline with low DPI has bad quality on Windows

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

• d7a6e51: 8253899: Make IsClassUnloadingEnabled signature match specification
• 293d44f: 8262017: C2: assert(n != __null) failed: Bad immediate dominator info.
• 2a3d908: 8269661: JNI_GetStringCritical does not lock char array
• 6762216: 8267666: Add option to jcmd GC.heap_dump to use existing file
• 63c4ec2: 8259535: ECDSA SignatureValue do not always have the specified length
• 133eca0: 8235211: serviceability/attach/RemovingUnixDomainSocketTest.java fails with AttachNotSupportedException: Unable to open socket file
• 7501084: 8268965: TCP Connection Reset when connecting simple socket to SSL server
• d78e2be: 8227738: jvmti/DataDumpRequest/datadumpreq001 failed due to "exit code is 134"
• 8637f65: 8227815: Minimal VM: set_state is not a member of AttachListener
• f3098c4: 8225690: Multiple AttachListener threads can be created
• ... and 63 more: https://git.openjdk.java.net/jdk11u-dev/compare/e56abcaaeedcb510537eee92a57109525a7e5951...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlexanderScherbatiy]

/integrate

[openjdk]

Going to push as commit 7639f8c.
Since your change was applied there have been 88 commits pushed to the master branch:

• 0e2d915: 8257620: Do not use objc_msgSend_stret to get macOS version
• 6e60332: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV
• 69697b3: 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration
• 95c94ae: 8209773: Refactor shell test javax/naming/module/basic.sh to java
• d7e852c: 8209930: Refactor java/util/zip/ZipFile/deletetempjar.sh to plain java test
• bb15820: 8042902: Test java/net/Inet6Address/serialize/Inet6AddressSerializationTest.java fails intermittently
• 69341be: 8261147: C2: Node is wrongly marked as reduction resulting in a wrong execution due to wrong vector instructions
• feee8ef: 8209832: Refactor jdk/internal/reflect/Reflection/GetCallerClassTest.sh to plain java test
• 57a7e71: 8194230: jdk/internal/jrtfs/remote/RemoteRuntimeImageTest.java fails with java.lang.NullPointerException
• adcfbd2: 8208227: tools/jdeps/DotFileTest.java fails on Win-X64
• ... and 78 more: https://git.openjdk.java.net/jdk11u-dev/compare/e56abcaaeedcb510537eee92a57109525a7e5951...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlexanderScherbatiy Pushed as commit 7639f8c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.