Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8240734: ModuleHashes attribute not reproducible between builds #915

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Mar 18, 2022

This is a clean backport of JDK-8240734. I'm backporting this as a predecessor of JDK-8243666.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8240734: ModuleHashes attribute not reproducible between builds

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/915/head:pull/915
$ git checkout pull/915

Update a local copy of the PR:
$ git checkout pull/915
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 915

View PR using the GUI difftool:
$ git pr show -t 915

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/915.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f4b54881811353ab61748db5af7f93b6c40efb2d 8240734: ModuleHashes attribute not reproducible between builds Mar 18, 2022
@openjdk
Copy link

openjdk bot commented Mar 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 18, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8240734: ModuleHashes attribute not reproducible between builds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 18, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 19, 2022

Going to push as commit e6f8c1e.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 23af0b1: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
  • 8f3308a: 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers
  • ca21a70: 8215544: SA: Modify ClhsdbLauncher to add sudo privileges to enable MacOS tests on Mach5
  • 63db1bf: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method
  • a3af00c: 8274233: Minor cleanup for ToolBox
  • 269114b: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support
  • d267171: 8231489: GC watermark_0_1 failed due to "metaspace.gc.Fault: GC has happened too rare"
  • 306d863: 8229486: Replace wildcard address with loopback or local host in tests - part 21

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 19, 2022
@openjdk openjdk bot closed this Mar 19, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2022
@openjdk
Copy link

openjdk bot commented Mar 19, 2022

@RealCLanger Pushed as commit e6f8c1e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants