Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8246494: introduce vm.flagless at-requires property #917

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 18, 2022

I backport this for parity with 11.0.16-oracle.

TEST.ROOT, GTestWrapper.java, VMProps.java
context, Copyright.

LargePageGtests.java, MetaspaceGtests.java:
not in 11


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8246494: introduce vm.flagless at-requires property

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/917/head:pull/917
$ git checkout pull/917

Update a local copy of the PR:
$ git checkout pull/917
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 917

View PR using the GUI difftool:
$ git pr show -t 917

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/917.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e333b6e15343535789353f0017721b6509eb4f00 8246494: introduce vm.flagless at-requires property Mar 18, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Mar 18, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 18, 2022

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8246494: introduce vm.flagless at-requires property

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 8f3308a: 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers
  • ca21a70: 8215544: SA: Modify ClhsdbLauncher to add sudo privileges to enable MacOS tests on Mach5
  • 63db1bf: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method
  • a3af00c: 8274233: Minor cleanup for ToolBox
  • 269114b: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support
  • d267171: 8231489: GC watermark_0_1 failed due to "metaspace.gc.Fault: GC has happened too rare"
  • 306d863: 8229486: Replace wildcard address with loopback or local host in tests - part 21
  • dbd14f7: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch
  • dfcef29: 8241707: introduce randomness k/w to hotspot test suite
  • b42dd74: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang
  • ... and 7 more: https://git.openjdk.java.net/jdk11u-dev/compare/90ac8aea0372a6f26592015ca42b98b109ac89f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 18, 2022
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Mar 20, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 20, 2022

Going to push as commit f14b932.
Since your change was applied there have been 21 commits pushed to the master branch:

  • e66e3e5: 8210108: sun/tools/jstatd test build failures after JDK-8210022
  • dd6ba08: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)
  • e6f8c1e: 8240734: ModuleHashes attribute not reproducible between builds
  • 23af0b1: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
  • 8f3308a: 8217473: SA: Tests using ClhsdbLauncher fail on SAP docker containers
  • ca21a70: 8215544: SA: Modify ClhsdbLauncher to add sudo privileges to enable MacOS tests on Mach5
  • 63db1bf: 8278186: org.jcp.xml.dsig.internal.dom.Utils.parseIdFromSameDocumentURI throws StringIndexOutOfBoundsException when calling substring method
  • a3af00c: 8274233: Minor cleanup for ToolBox
  • 269114b: 8269933: test/jdk/javax/net/ssl/compatibility/JdkInfo incorrect verification of protocol and cipher support
  • d267171: 8231489: GC watermark_0_1 failed due to "metaspace.gc.Fault: GC has happened too rare"
  • ... and 11 more: https://git.openjdk.java.net/jdk11u-dev/compare/90ac8aea0372a6f26592015ca42b98b109ac89f7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 20, 2022
@openjdk openjdk bot closed this Mar 20, 2022
@openjdk openjdk bot removed ready rfr labels Mar 20, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 20, 2022

@GoeLin Pushed as commit f14b932.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8246494 branch Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants