Skip to content

8210108: sun/tools/jstatd test build failures after JDK-8210022 #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Mar 19, 2022

Hi all,

I'd like to backport this patch to fix the following testing failures.

sun/tools/jstatd/TestJstatdDefaults.java
sun/tools/jstatd/TestJstatdServer.java
sun/tools/jstatd/TestJstatdPort.java
sun/tools/jstatd/TestJstatdExternalRegistry.java
sun/tools/jstatd/TestJstatdPortAndServer.java

Thanks.
Best regards,
Jie


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8210108: sun/tools/jstatd test build failures after JDK-8210022

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/922/head:pull/922
$ git checkout pull/922

Update a local copy of the PR:
$ git checkout pull/922
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 922

View PR using the GUI difftool:
$ git pr show -t 922

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/922.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2022

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 86c476b5e5e0cc00c40e7049d1dbb02874afe247 8210108: sun/tools/jstatd test build failures after JDK-8210022 Mar 19, 2022
@openjdk
Copy link

openjdk bot commented Mar 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 19, 2022

@DamonFool This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210108: sun/tools/jstatd test build failures after JDK-8210022

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • dd6ba08: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)
  • e6f8c1e: 8240734: ModuleHashes attribute not reproducible between builds

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 19, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2022

Webrevs

@DamonFool
Copy link
Member Author

Fix request had been approved.
So integrate it.
Thanks.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 20, 2022
@openjdk
Copy link

openjdk bot commented Mar 20, 2022

@DamonFool
Your change (at version ec6007d) is now ready to be sponsored by a Committer.

@johnshajiang
Copy link
Member

/integrate

@johnshajiang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 20, 2022

@johnshajiang Only the author (@DamonFool) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@openjdk
Copy link

openjdk bot commented Mar 20, 2022

Going to push as commit e66e3e5.
Since your change was applied there have been 2 commits pushed to the master branch:

  • dd6ba08: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)
  • e6f8c1e: 8240734: ModuleHashes attribute not reproducible between builds

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 20, 2022
@openjdk openjdk bot closed this Mar 20, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 20, 2022
@openjdk
Copy link

openjdk bot commented Mar 20, 2022

@johnshajiang @DamonFool Pushed as commit e66e3e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants