-
Notifications
You must be signed in to change notification settings - Fork 238
8210108: sun/tools/jstatd test build failures after JDK-8210022 #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@DamonFool This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Fix request had been approved. /integrate |
@DamonFool |
/integrate |
/sponsor |
@johnshajiang Only the author (@DamonFool) is allowed to issue the |
Going to push as commit e66e3e5.
Your commit was automatically rebased without conflicts. |
@johnshajiang @DamonFool Pushed as commit e66e3e5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
I'd like to backport this patch to fix the following testing failures.
Thanks.
Best regards,
Jie
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/922/head:pull/922
$ git checkout pull/922
Update a local copy of the PR:
$ git checkout pull/922
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/922/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 922
View PR using the GUI difftool:
$ git pr show -t 922
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/922.diff