Skip to content

8283420: [AOT] Exclude TrackedFlagTest/NotTrackedFlagTest in 11u because of intermittent java.lang.AssertionError: duplicate classes for name Ljava/lang/Boolean; #923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Mar 19, 2022

We see intermittent errors in our CI systems, like here:
https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/61/
https://ci.sapmachine.io/job/build-11-pr-validation-linux_x86_64/53/

The issue would only be fixed with a Graal update (https://bugs.openjdk.java.net/browse/JDK-8215224 from OpenJDK 12) which is probably not going to happen in OpenJDK 11u.
So we shall exclude these two tests to reduce noise in CI systems.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283420: [AOT] Exclude TrackedFlagTest/NotTrackedFlagTest in 11u because of intermittent java.lang.AssertionError: duplicate classes for name Ljava/lang/Boolean;

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/923/head:pull/923
$ git checkout pull/923

Update a local copy of the PR:
$ git checkout pull/923
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/923/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 923

View PR using the GUI difftool:
$ git pr show -t 923

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/923.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 19, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

GHA error unrelated - runtime/Thread/StopAtExit.java will be fixed with JDK-8283270.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Mar 20, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283420: [AOT] Exclude TrackedFlagTest/NotTrackedFlagTest in 11u because of intermittent java.lang.AssertionError: duplicate classes for name Ljava/lang/Boolean;

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e66e3e5: 8210108: sun/tools/jstatd test build failures after JDK-8210022

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 20, 2022
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 21, 2022

Going to push as commit d568fc8.
Since your change was applied there have been 5 commits pushed to the master branch:

  • bb54eeb: 8209883: ZGC: Compile without C1 broken
  • 6e5000f: 8283424: compiler/loopopts/LoopUnswitchingBadNodeBudget.java fails with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions
  • cf52a6f: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
  • f14b932: 8246494: introduce vm.flagless at-requires property
  • e66e3e5: 8210108: sun/tools/jstatd test build failures after JDK-8210022

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 21, 2022
@openjdk openjdk bot closed this Mar 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

@RealCLanger Pushed as commit d568fc8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the 8283420 branch March 21, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants