-
Notifications
You must be signed in to change notification settings - Fork 253
8261169: Upgrade HarfBuzz to the latest 2.8.0 #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks good. Harfbuzz matches the version from 13u-dev exactly, now.
Note that Skara doesn't recognize it as backport. I suggest to change the bug id to JDK-8267977 which was already created for this backport.
Please check if https://bugs.openjdk.java.net/browse/JDK-8266545 is also needed.
|
@MBaesken This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
|
Going to push as commit 088445f.
Your commit was automatically rebased without conflicts. |
Hello, I would like to backport harfbuzz 2.8.0 to 11u-dev, so that a current harfbuzz version is used there that includes latest fixes. Awt2dLibraries.gmk needed a bit of manual adjustments.
As a preparation https://bugs.openjdk.java.net/browse/JDK-8282588 had been done recently.
Discussion about this issue
https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-January/thread.html#11411
https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/thread.html#11937
https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-March/thread.html#12497
Thanks, Matthias
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/929/head:pull/929$ git checkout pull/929Update a local copy of the PR:
$ git checkout pull/929$ git pull https://git.openjdk.java.net/jdk11u-dev pull/929/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 929View PR using the GUI difftool:
$ git pr show -t 929Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/929.diff