Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 21, 2022

I backport this for parity with 11.0.16-oracle.

I had to adapt the change in some places, all quite trivial:

TestTrichotomyExpressions.java
TestShift.java
Vec_MulAddS2I.java
These tests are not in 11. Skipped.

ClearDirectivesFileStackTest.java
Resolved Copyright.

UnsafeIntrinsicsTest.java
A later change doubling the test description was already backported.
Applying the patch was trivial.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242310: use reproducible random in hotspot compiler tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/930/head:pull/930
$ git checkout pull/930

Update a local copy of the PR:
$ git checkout pull/930
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/930/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 930

View PR using the GUI difftool:
$ git pr show -t 930

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/930.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7c351405c4a43c8af40a63f63b70bfcb7719b570 8242310: use reproducible random in hotspot compiler tests Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Mar 21, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 21, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the detailed description.

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242310: use reproducible random in hotspot compiler tests

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 79c45a5: 8278851: Correct signer logic for jars signed with multiple digestalgs
  • 31d7b5e: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1
  • 7c29f0e: 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps
  • 03da67b: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • 9714b69: 8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 22, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Mar 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

Going to push as commit 078eac8.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2022
@openjdk openjdk bot closed this Mar 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@GoeLin Pushed as commit 078eac8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8242310 branch March 24, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants