Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242311: use reproducible random in hotspot runtime tests #932

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 21, 2022

I backport this for parity with 11.0.16-oracle.

SharedArchiveConsistency.java
GCStressApp.java
GCStressTest.java
Test were moved, patch applies with the following edits if the paths are adapted:
Copyright in GCStressApp.java
Copyright, test description in GCStressTest.java

This test is not in 11: NullPointerExceptionTest.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242311: use reproducible random in hotspot runtime tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/932/head:pull/932
$ git checkout pull/932

Update a local copy of the PR:
$ git checkout pull/932
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/932/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 932

View PR using the GUI difftool:
$ git pr show -t 932

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/932.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 21, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c73934d8c8dcc81c85f770ce303f2cb47823785f 8242311: use reproducible random in hotspot runtime tests Mar 21, 2022
@openjdk
Copy link

openjdk bot commented Mar 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 21, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 21, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242311: use reproducible random in hotspot runtime tests

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 79c45a5: 8278851: Correct signer logic for jars signed with multiple digestalgs
  • 31d7b5e: 8222926: Shenandoah build fails with --with-jvm-features=-compiler1
  • 7c29f0e: 8243666: ModuleHashes attribute generated for JMOD and JAR files depends on timestamps
  • 03da67b: 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • 9714b69: 8206330: Revisit com/sun/jdi/RedefineCrossEvent.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 22, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Mar 24, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

Going to push as commit c152474.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2022
@openjdk openjdk bot closed this Mar 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2022
@GoeLin GoeLin deleted the goetz_backport_8242311 branch March 24, 2022 13:41
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@GoeLin Pushed as commit c152474.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants