Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 #939

Closed
wants to merge 3 commits into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Mar 23, 2022

backport of 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/939/head:pull/939
$ git checkout pull/939

Update a local copy of the PR:
$ git checkout pull/939
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/939/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 939

View PR using the GUI difftool:
$ git pr show -t 939

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/939.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@MBaesken MBaesken changed the title M baesken backport a86ee9b3 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 Mar 23, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 23, 2022

Webrevs

@MBaesken MBaesken closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
1 participant