Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253714: [cgroups v2] Soft memory limit incorrectly using memory.high #941

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 23, 2022

A clean backport to replace dependency PR 865 that resulted many conflicts.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8253714: [cgroups v2] Soft memory limit incorrectly using memory.high

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/941/head:pull/941
$ git checkout pull/941

Update a local copy of the PR:
$ git checkout pull/941
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/941/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 941

View PR using the GUI difftool:
$ git pr show -t 941

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/941.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 23, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ff6843ca4842498791061f924c545fa9469cc1dc 8253714: [cgroups v2] Soft memory limit incorrectly using memory.high Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253714: [cgroups v2] Soft memory limit incorrectly using memory.high

The early implementation of cgroups v2 support was done with
crun 0.8 and it contained a bug which set memory.high over
memory.low when --memory-reservation was being used as a CLI
option.

This bug has been fixed in later crun versions, starting with
crun 0.11. Use memory.low in OpenJDK as well.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 23, 2022
@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Mar 23, 2022

/integrate

@mlbridge
Copy link

mlbridge bot commented Mar 23, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Mar 23, 2022

Going to push as commit f76091e.

@openjdk openjdk bot added the integrated label Mar 23, 2022
@openjdk openjdk bot closed this Mar 23, 2022
@openjdk openjdk bot removed ready rfr labels Mar 23, 2022
@openjdk
Copy link

openjdk bot commented Mar 23, 2022

@zhengyu123 Pushed as commit f76091e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant