Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256722: handle VC++:1927 VS2019 in abstract_vm_version #944

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Mar 24, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8256722: handle VC++:1927 VS2019 in abstract_vm_version

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/944/head:pull/944
$ git checkout pull/944

Update a local copy of the PR:
$ git checkout pull/944
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/944/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 944

View PR using the GUI difftool:
$ git pr show -t 944

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/944.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 24, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e838d71d6151655980c8a96673f5db65f9168aee 8256722: handle VC++:1927 VS2019 in abstract_vm_version Mar 24, 2022
@openjdk
Copy link

openjdk bot commented Mar 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 24, 2022

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256722: handle VC++:1927 VS2019 in  abstract_vm_version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Mar 24, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 24, 2022

Webrevs

@MBaesken
Copy link
Member Author

MBaesken commented Mar 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

Going to push as commit 146fe86.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 588bdfa: 8274751: Drag And Drop hangs on Windows
  • e6020c3: 6986863: ProfileDeferralMgr throwing ConcurrentModificationException
  • f3b76ae: 8282583: Update BCEL md to include the copyright notice
  • 8eeba89: 8281275: Upgrading from 8 to 11 no longer accepts '/' as filepath separator in gc paths
  • 6aecb15: 8278472: Invalid value set to CANDIDATEFORM structure
  • c152474: 8242311: use reproducible random in hotspot runtime tests
  • d064d8e: 8242313: use reproducible random in hotspot svc tests
  • 078eac8: 8242310: use reproducible random in hotspot compiler tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 28, 2022
@openjdk openjdk bot closed this Mar 28, 2022
@openjdk openjdk bot removed ready rfr labels Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@MBaesken Pushed as commit 146fe86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant