Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8276657: XSLT compiler tries to define a class with empty name #947

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Mar 25, 2022

Backport of JDK-8276657 as per request of Cheng Jin
http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-March/012660.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8276657: XSLT compiler tries to define a class with empty name

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/947/head:pull/947
$ git checkout pull/947

Update a local copy of the PR:
$ git checkout pull/947
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/947/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 947

View PR using the GUI difftool:
$ git pr show -t 947

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/947.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3c6aecd395e2dd6829815dcaa9d0e17d252131ed 8276657: XSLT compiler tries to define a class with empty name Mar 25, 2022
@openjdk
Copy link

openjdk bot commented Mar 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 25, 2022
@RealCLanger
Copy link
Contributor Author

Backport is clean, I only had to resolve the @lastmodified tag.
/clean

@openjdk openjdk bot added the clean label Mar 25, 2022
@openjdk
Copy link

openjdk bot commented Mar 25, 2022

@RealCLanger This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Mar 25, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8276657: XSLT compiler tries to define a class with empty name

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 25, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

Going to push as commit 358fc5a.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 2049fca: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
  • 2bb6a3b: 8266391: Replace use of reflection in jdk.internal.platform.Metrics
  • 27b388c: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  • 29b0b63: 8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes
  • d5ae8cf: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
  • 146fe86: 8256722: handle VC++:1927 VS2019 in abstract_vm_version
  • 588bdfa: 8274751: Drag And Drop hangs on Windows
  • e6020c3: 6986863: ProfileDeferralMgr throwing ConcurrentModificationException

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 28, 2022
@openjdk openjdk bot closed this Mar 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@RealCLanger Pushed as commit 358fc5a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-3c6aecd3 branch March 28, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant