Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259517: Incorrect test path in test cases #952

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 28, 2022

I backport this for parity with 11.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/952/head:pull/952
$ git checkout pull/952

Update a local copy of the PR:
$ git checkout pull/952
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/952/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 952

View PR using the GUI difftool:
$ git pr show -t 952

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/952.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 81db63e8d74c0d85cdadb0a70580a33c79d0bb80 8259517: Incorrect test path in test cases Mar 28, 2022
@openjdk
Copy link

openjdk bot commented Mar 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 28, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259517: Incorrect test path in test cases

Reviewed-by: xuelei

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 358fc5a: 8276657: XSLT compiler tries to define a class with empty name
  • 2049fca: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
  • 2bb6a3b: 8266391: Replace use of reflection in jdk.internal.platform.Metrics
  • 27b388c: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  • 29b0b63: 8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes
  • d5ae8cf: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
  • 146fe86: 8256722: handle VC++:1927 VS2019 in abstract_vm_version

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 28, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2022

Webrevs

Copy link
Member

@XueleiFan XueleiFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like a safe backport to me. Thanks!

@GoeLin
Copy link
Member Author

GoeLin commented Mar 29, 2022

Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

Going to push as commit 68a9e01.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 389ac32: 8182404: remove jdk.testlibrary.JDKToolFinder and JDKToolLauncher
  • 9aa728e: 8210112: remove jdk.testlibrary.ProcessTools
  • 6518636: 8273176: handle latest VS2019 in abstract_vm_version
  • 358fc5a: 8276657: XSLT compiler tries to define a class with empty name
  • 2049fca: 8244500: jtreg test error in test/hotspot/jtreg/containers/docker/TestMemoryAwareness.java
  • 2bb6a3b: 8266391: Replace use of reflection in jdk.internal.platform.Metrics
  • 27b388c: 8252957: Wrong comment in CgroupV1Subsystem::cpu_quota
  • 29b0b63: 8254997: Remove unimplemented OSContainer::read_memory_limit_in_bytes
  • d5ae8cf: 8239785: Cgroups: Incorrect detection logic on old systems in hotspot
  • 146fe86: 8256722: handle VC++:1927 VS2019 in abstract_vm_version

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 29, 2022
@openjdk openjdk bot closed this Mar 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@GoeLin Pushed as commit 68a9e01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants