-
Notifications
You must be signed in to change notification settings - Fork 252
8266318: Switch to macos prefix for macOS bundles #958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix typo.
|
Thanks for spotting this! Fixed. |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 91 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
Pre-submit failures |
|
/integrate |
|
Going to push as commit d279487.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.16-oracle.
platform.m4: Resolved copyright.
jib-proviles.js: macos-aarch64 not listed. Skipped.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/958/head:pull/958$ git checkout pull/958Update a local copy of the PR:
$ git checkout pull/958$ git pull https://git.openjdk.java.net/jdk11u-dev pull/958/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 958View PR using the GUI difftool:
$ git pr show -t 958Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/958.diff