Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8168304: Make all of DependencyContext_test available in product mode #96

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Jul 2, 2021

Unclean backport, because there is find_stale_entries too.

Additional testing:

  • Affected test on Linux x86_64 fastdebug
  • Affected test on Linux x86_64 release

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8168304: Make all of DependencyContext_test available in product mode

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/96/head:pull/96
$ git checkout pull/96

Update a local copy of the PR:
$ git checkout pull/96
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/96/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 96

View PR using the GUI difftool:
$ git pr show -t 96

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/96.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 2, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 66c8794c8141632d730a87643e898c6d4951daee 8168304: Make all of DependencyContext_test available in product mode Jul 2, 2021
@openjdk
Copy link

openjdk bot commented Jul 2, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr labels Jul 2, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 2, 2021

Webrevs

@shipilev
Copy link
Contributor Author

shipilev commented Jul 28, 2021

Friendly reminder.

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@openjdk
Copy link

openjdk bot commented Aug 3, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8168304: Make all of DependencyContext_test available in product mode

Enable the utility inspection function `DependencyContext::is_dependent_method` and therefore the test in the product mode.

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 119 new commits pushed to the master branch:

  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 05c7697: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 37bc75b: 8241768: git needs .gitattributes
  • 351cb48: 8225583: Examine the HttpResponse.BodySubscribers for null handling and multiple subscriptions
  • 8ae2846: 8232243: Wrong caret position in JTextPane on Windows with a screen resolution > 100%
  • a2af649: 8268775: Password is being converted to String in AccessibleJPasswordField
  • 7639f8c: 8262470: Printed GlyphVector outline with low DPI has bad quality on Windows
  • 0e2d915: 8257620: Do not use objc_msgSend_stret to get macOS version
  • 6e60332: 8269795: C2: Out of bounds array load floats above its range check in loop peeling resulting in SEGV
  • ... and 109 more: https://git.openjdk.java.net/jdk11u-dev/compare/df587c75bb436b40dd995e39ee0ed952a74b979b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 3, 2021
@shipilev
Copy link
Contributor Author

shipilev commented Aug 4, 2021

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 4, 2021

Going to push as commit 35fcac6.
Since your change was applied there have been 122 commits pushed to the master branch:

  • cf2cf25: 8266761: AssertionError in sun.net.httpserver.ServerImpl.responseCompleted
  • 0c783b0: 8257497: Update keytool to create AKID from the SKID of the issuing certificate as specified by RFC 5280
  • aebdee3: 8230674: Heap dumps should exclude dormant CDS archived objects of unloaded classes
  • 815d3e1: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 4da3fb8: 8268261: C2: assert(n != __null) failed: Bad immediate dominator info.
  • 05c7697: 8269668: [aarch64] java.library.path not including /usr/lib64
  • 37bc75b: 8241768: git needs .gitattributes
  • 351cb48: 8225583: Examine the HttpResponse.BodySubscribers for null handling and multiple subscriptions
  • 8ae2846: 8232243: Wrong caret position in JTextPane on Windows with a screen resolution > 100%
  • a2af649: 8268775: Password is being converted to String in AccessibleJPasswordField
  • ... and 112 more: https://git.openjdk.java.net/jdk11u-dev/compare/df587c75bb436b40dd995e39ee0ed952a74b979b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Aug 4, 2021
@openjdk
Copy link

openjdk bot commented Aug 4, 2021

@shipilev Pushed as commit 35fcac6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants