New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8270797: ShortECDSA.java test is not complete #963
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
Pre-submit tests: missing dependencies, fixed by now. |
/integrate |
Going to push as commit 319309e.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.16-oracle.
I had to fix the call to HexFormat in one place. That class is not in 11.
Similar fix has been made before to the same test.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/963/head:pull/963
$ git checkout pull/963
Update a local copy of the PR:
$ git checkout pull/963
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/963/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 963
View PR using the GUI difftool:
$ git pr show -t 963
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/963.diff