Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270797: ShortECDSA.java test is not complete #963

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 29, 2022

I backport this for parity with 11.0.16-oracle.

I had to fix the call to HexFormat in one place. That class is not in 11.
Similar fix has been made before to the same test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/963/head:pull/963
$ git checkout pull/963

Update a local copy of the PR:
$ git checkout pull/963
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 963

View PR using the GUI difftool:
$ git pr show -t 963

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/963.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 29, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 221e4b9c61cd1c9c3f4c037589ba639541532910 8270797: ShortECDSA.java test is not complete Mar 29, 2022
@openjdk
Copy link

openjdk bot commented Mar 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 29, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 29, 2022

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Mar 29, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8270797: ShortECDSA.java test is not complete

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 29, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Mar 31, 2022

Pre-submit tests: missing dependencies, fixed by now.

@GoeLin
Copy link
Member Author

GoeLin commented Apr 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

Going to push as commit 319309e.
Since your change was applied there have been 23 commits pushed to the master branch:

  • 164febe: 8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect
  • 4a045a7: 8247614: java/nio/channels/DatagramChannel/Connect.java timed out
  • f2b92d0: 8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
  • 21d20bd: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"
  • 880e1ab: 8192057: com/sun/jdi/BadHandshakeTest.java fails with java.net.ConnectException
  • e937be3: 8214799: Add package declaration to each JTREG test case in the gc folder
  • 156c486: 8235385: Crash on aarch64 JDK due to long offset
  • 01c4d3f: 8278065: Refactor subclassAudits to use ClassValue
  • b1f18cb: 8280041: Retry loop issues in java.io.ClassCache
  • 118ec61: 8277072: ObjectStreamClass caches keep ClassLoaders alive
  • ... and 13 more: https://git.openjdk.java.net/jdk11u-dev/compare/5ed1009dc202a5f0dc3559b0242dbacac7c051b2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2022
@openjdk openjdk bot closed this Apr 1, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Apr 1, 2022
@GoeLin GoeLin deleted the goetz_backport_8270797 branch April 1, 2022 09:07
@openjdk openjdk bot removed the rfr Pull request is ready for review label Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@GoeLin Pushed as commit 319309e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants