Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows #965

Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Mar 30, 2022

A clean and low risk backport to fix a memory leak.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/965/head:pull/965
$ git checkout pull/965

Update a local copy of the PR:
$ git checkout pull/965
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/965/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 965

View PR using the GUI difftool:
$ git pr show -t 965

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/965.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2cddf3f5391518ea40796e6c4759047d51b7b312 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 30, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • c2e43f7: Merge
  • 487c334: 8283778: 11u GHA: Fix GCC 9 ubuntu package names
  • 0413680: 8283018: 11u GHA: Update GCC 9 minor versions
  • af99bc3: 8275082: Update XML Security for Java to 2.3.0

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Mar 31, 2022

Hi @zhengyu123,
what's the problem with the tests, especially windows?

@zhengyu123
Copy link
Contributor Author

Hi @zhengyu123, what's the problem with the tests, especially windows?

Looks like environment problem. that failed to install cygwin. I will re-run the tests

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Apr 4, 2022

Going to push as commit 2f1bee6.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 4c8b099: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
  • 34ed681: 8283497: [windows] print TMP and TEMP in hs_err and VM.info
  • 319309e: 8270797: ShortECDSA.java test is not complete
  • 164febe: 8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect
  • 4a045a7: 8247614: java/nio/channels/DatagramChannel/Connect.java timed out
  • f2b92d0: 8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
  • 21d20bd: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"
  • 880e1ab: 8192057: com/sun/jdi/BadHandshakeTest.java fails with java.net.ConnectException
  • e937be3: 8214799: Add package declaration to each JTREG test case in the gc folder
  • 156c486: 8235385: Crash on aarch64 JDK due to long offset
  • ... and 16 more: https://git.openjdk.java.net/jdk11u-dev/compare/5ed1009dc202a5f0dc3559b0242dbacac7c051b2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2022
@openjdk openjdk bot closed this Apr 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@zhengyu123 Pushed as commit 2f1bee6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants