Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279958: Provide configure hints for Alpine/apk package managers #969

Closed
wants to merge 1 commit into from

Conversation

voitylov
Copy link

@voitylov voitylov commented Mar 30, 2022

JDK-8279958 is a follow up issue of a chain of backports for Alpine support to 11u, adding configure hints for Alpine.

Original changeset does not apply cleanly because of:

8219920: dependency help output in configure-step : support zypper tool
8257679: Improved unix compatibility layer in Windows build (winenv)

Testing: configure produced expected output, GHA.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279958: Provide configure hints for Alpine/apk package managers

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/969/head:pull/969
$ git checkout pull/969

Update a local copy of the PR:
$ git checkout pull/969
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 969

View PR using the GUI difftool:
$ git pr show -t 969

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/969.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2022

👋 Welcome back avoitylov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a30aa52b77931bcea38213cf3d243d18a37dc858 8279958: Provide configure hints for Alpine/apk package managers Mar 30, 2022
@openjdk
Copy link

openjdk bot commented Mar 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 30, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 30, 2022

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@voitylov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279958: Provide configure hints for Alpine/apk package managers

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 31, 2022
@voitylov
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 31, 2022
@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@voitylov
Your change (at version 1c68a2c) is now ready to be sponsored by a Committer.

@AlexanderScherbatiy
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 31, 2022

Going to push as commit 9bedb0f.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 31, 2022
@openjdk openjdk bot closed this Mar 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 31, 2022
@openjdk
Copy link

openjdk bot commented Mar 31, 2022

@AlexanderScherbatiy @voitylov Pushed as commit 9bedb0f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants