8224853: CDS address sanitizer errors

[shipilev]

This is the unclean backport, because the affected ReadClosure and WriteClosure moved around for CDS work in later JDKs.

Additional testing:

• Linux x86_64 fastdebug, --enable-asan, -XX:+DumpSharedSpaces tests (used to fail, now pass)
• Linux x86_64 fastdebug, runtime/cds tests (still pass)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8224853: CDS address sanitizer errors

Reviewers

• Jiangli Zhou (@jianglizhou - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/97/head:pull/97
$ git checkout pull/97

Update a local copy of the PR:
$ git checkout pull/97
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/97/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 97

View PR using the GUI difftool:
$ git pr show -t 97

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/97.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (9c293425)

[jianglizhou]

Looks good.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8224853: CDS address sanitizer errors

Reviewed-by: jiangli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 73e987c: 8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark
• 71f793e: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• e56abca: 8268366: Incorrect calculation of has_fpu_registers in C1 linear scan
• 3ed6237: 8269614: [s390] Interpreter checks wrong bit for slow path instance allocation
• aa79d2b: 8262409: sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions. SSL test failures caused by java failed with "Server reported the wrong exception"
• 65fe466: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
• af4b373: 8163326: Update the default enabled cipher suites preference
• 02bfc22: 8266749: AArch64: Backtracing broken on PAC enabled systems
• 0e4fdcf: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image
• 725e516: Merge
• ... and 15 more: https://git.openjdk.java.net/jdk11u-dev/compare/df587c75bb436b40dd995e39ee0ed952a74b979b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

/integrate

[openjdk]

Going to push as commit 3f03476.
Since your change was applied there have been 30 commits pushed to the master branch:

• 65b215a: 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test
• c61cfb5: 8255718: Zero: VM should know it runs in interpreter-only mode
• 3e09f94: 8260923: Add more tests for SSLSocket input/output shutdown
• c00a72f: 8253631: Remove unimplemented CompileBroker methods after JEP-165
• 21345ef: 8269847: JDK-8269594 backport breaks 11u builds
• 73e987c: 8269594: assert(_handle_mark_nesting > 1) failed: memory leak: allocating handle outside HandleMark
• 71f793e: 8266404: Fatal error report generated with -XX:+CrashOnOutOfMemoryError should not contain suggestion to submit a bug report
• e56abca: 8268366: Incorrect calculation of has_fpu_registers in C1 linear scan
• 3ed6237: 8269614: [s390] Interpreter checks wrong bit for slow path instance allocation
• aa79d2b: 8262409: sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions. SSL test failures caused by java failed with "Server reported the wrong exception"
• ... and 20 more: https://git.openjdk.java.net/jdk11u-dev/compare/df587c75bb436b40dd995e39ee0ed952a74b979b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 3f03476.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.