Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect" #972

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 31, 2022

I backport this for parity with 11.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/972/head:pull/972
$ git checkout pull/972

Update a local copy of the PR:
$ git checkout pull/972
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 972

View PR using the GUI difftool:
$ git pr show -t 972

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/972.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 31, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/968 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1d245c6ec824c19d24793e00bfedc92a11c18041 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect" Mar 31, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 31, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr labels Mar 31, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 31, 2022

Webrevs

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Apr 1, 2022

Pre-submit failure: infrastructure problem
curl: (28) Failed to connect to www.cygwin.com port 443 after 21110 ms: Timed out

@GoeLin GoeLin changed the base branch from pr/968 to master Apr 1, 2022
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Apr 1, 2022

/integrate

@openjdk openjdk bot removed the clean label Apr 1, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2022

@GoeLin This pull request has not yet been marked as ready for integration.

@openjdk openjdk bot added the clean label Apr 1, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 1, 2022
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Apr 1, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2022

Going to push as commit 21d20bd.

@openjdk openjdk bot added the integrated label Apr 1, 2022
@openjdk openjdk bot closed this Apr 1, 2022
@openjdk openjdk bot removed ready rfr labels Apr 1, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 1, 2022

@GoeLin Pushed as commit 21d20bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8252117 branch Apr 1, 2022
@GoeLin GoeLin restored the goetz_backport_8252117 branch Apr 1, 2022
@GoeLin GoeLin deleted the goetz_backport_8252117 branch Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant