Skip to content

8283497: [windows] print TMP and TEMP in hs_err and VM.info #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Apr 1, 2022

I'd like to have this in jdk11. Super trivial, applies cleanly. Helps with error analysis e.g. with jdk.attach.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8283497: [windows] print TMP and TEMP in hs_err and VM.info

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/974/head:pull/974
$ git checkout pull/974

Update a local copy of the PR:
$ git checkout pull/974
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/974/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 974

View PR using the GUI difftool:
$ git pr show -t 974

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/974.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b035fda459284fa130bf936743a8579a6888160b 8283497: [windows] print TMP and TEMP in hs_err and VM.info Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283497: [windows] print TMP and TEMP in hs_err and VM.info

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2022

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Apr 1, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

Going to push as commit 34ed681.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 319309e: 8270797: ShortECDSA.java test is not complete
  • 164febe: 8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect
  • 4a045a7: 8247614: java/nio/channels/DatagramChannel/Connect.java timed out
  • f2b92d0: 8253872: ArgumentHandler must use the same delimiters as in jvmti_tools.cpp
  • 21d20bd: 8252117: com/sun/jdi/BadHandshakeTest.java failed with "ConnectException: Connection refused: connect"
  • 880e1ab: 8192057: com/sun/jdi/BadHandshakeTest.java fails with java.net.ConnectException
  • e937be3: 8214799: Add package declaration to each JTREG test case in the gc folder
  • 156c486: 8235385: Crash on aarch64 JDK due to long offset
  • 01c4d3f: 8278065: Refactor subclassAudits to use ClassValue
  • b1f18cb: 8280041: Retry loop issues in java.io.ClassCache
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/0182066bacc35bd015ebd925b0e0fe45b9e3b276...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2022
@openjdk openjdk bot closed this Apr 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@tstuefe Pushed as commit 34ed681.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant