Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test #98

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 3, 2021

identrustdstx3 is expiring soon. Test is failing in jdk11u since today. I see 11.0.13-oracle as well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/98/head:pull/98
$ git checkout pull/98

Update a local copy of the PR:
$ git checkout pull/98
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/98/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 98

View PR using the GUI difftool:
$ git pr show -t 98

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/98.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 3, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 54f5ffeaad9da7cc77d9b6c0339758340c42ea2e 8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test Jul 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 3, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 3, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259338: Add expiry exception for identrustdstx3 alias to VerifyCACerts.java test

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • c61cfb5: 8255718: Zero: VM should know it runs in interpreter-only mode
  • 3e09f94: 8260923: Add more tests for SSLSocket input/output shutdown
  • c00a72f: 8253631: Remove unimplemented CompileBroker methods after JEP-165
  • 21345ef: 8269847: JDK-8269594 backport breaks 11u builds

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jul 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 3, 2021

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

Looks good. The absence of this fix breaks tier1 :)

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 5, 2021

Looks good. The absence of this fix breaks tier1 :)

Yep. Waiting for JBS approval by @jerboaa

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2021

Going to push as commit 65b215a.
Since your change was applied there have been 4 commits pushed to the master branch:

  • c61cfb5: 8255718: Zero: VM should know it runs in interpreter-only mode
  • 3e09f94: 8260923: Add more tests for SSLSocket input/output shutdown
  • c00a72f: 8253631: Remove unimplemented CompileBroker methods after JEP-165
  • 21345ef: 8269847: JDK-8269594 backport breaks 11u builds

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 5, 2021

@RealCLanger Pushed as commit 65b215a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants