Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256146: Cleanup test/jdk/java/nio/channels/DatagramChannel/Connect.java #982

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Apr 1, 2022

I backport this for parity with 11.0.16-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8256146: Cleanup test/jdk/java/nio/channels/DatagramChannel/Connect.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/982/head:pull/982
$ git checkout pull/982

Update a local copy of the PR:
$ git checkout pull/982
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 982

View PR using the GUI difftool:
$ git pr show -t 982

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/982.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9dbbe83a060e600221e0ea8c3463cfe88535d075 8256146: Cleanup test/jdk/java/nio/channels/DatagramChannel/Connect.java Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256146: Cleanup test/jdk/java/nio/channels/DatagramChannel/Connect.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Apr 2, 2022

Pre-submit failure: curl: (28) Failed to connect to www.cygwin.com ; Unrelated.

@GoeLin
Copy link
Member Author

GoeLin commented Apr 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2022

Going to push as commit 1b940f3.
Since your change was applied there have been 10 commits pushed to the master branch:

  • cd591e4: 8254887: C2: assert(cl->trip_count() > 0) failed: peeling a fully unrolled loop
  • aeb7ecf: 8243429: use reproducible random in :vmTestbase_nsk_stress
  • 9bca81b: 8240335: C2: assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • a3f9671: 8220813: update hotspot tier1_gc tests depending on GC to use @requires vm.gc.X
  • 01dec8f: 8282382: Report glibc malloc tunables in error reports
  • 19ccccc: 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist
  • 3cf4e70: 8252359: HotSpot Not Identifying it is Running in a Container
  • 2f1bee6: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows
  • 4c8b099: 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10
  • 34ed681: 8283497: [windows] print TMP and TEMP in hs_err and VM.info

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2022
@openjdk openjdk bot closed this Apr 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2022
@openjdk
Copy link

openjdk bot commented Apr 5, 2022

@GoeLin Pushed as commit 1b940f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant