Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 #984

Closed
wants to merge 2 commits into from

Conversation

jmtd
Copy link

@jmtd jmtd commented Apr 1, 2022

Part of cgroups v2 backport works. Conflict on copyright line. local testing: v1 system passed; v2 system with no user delegated cpu controller failed, this is fixed by later bug 8250984. I am about to verify v2 with delegated cpu controller locally and will update this when I have the result.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/984/head:pull/984
$ git checkout pull/984

Update a local copy of the PR:
$ git checkout pull/984
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/984/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 984

View PR using the GUI difftool:
$ git pr show -t 984

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/984.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2022

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 35172cdaf38d83cd3ed57a5436bf985dde2d802b 8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10 Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Apr 1, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2022

Webrevs

jerboaa
jerboaa approved these changes Apr 1, 2022
Copy link
Contributor

@jerboaa jerboaa left a comment

LGTM.

Aside: JDK-8250984 is already in JDK 11u, so that backport cannot fix anything at this point. Any fixes would need to be done as a 11u-specific bug.

@jmtd
Copy link
Author

jmtd commented Apr 1, 2022

Update on testing: test passes after I manually configure cpu cgroup delegation to user process heirarchy on my host; it was not enabled by default.

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278951: containers/cgroup/PlainRead.java fails on Ubuntu 21.10

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 34ed681: 8283497: [windows] print TMP and TEMP in hs_err and VM.info
  • 319309e: 8270797: ShortECDSA.java test is not complete
  • 164febe: 8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 1, 2022
@jmtd
Copy link
Author

jmtd commented Apr 1, 2022

/integrate

@openjdk openjdk bot added the sponsor label Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@jmtd
Your change (at version 0b00439) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Apr 1, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

Going to push as commit 4c8b099.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 34ed681: 8283497: [windows] print TMP and TEMP in hs_err and VM.info
  • 319309e: 8270797: ShortECDSA.java test is not complete
  • 164febe: 8255604: java/nio/channels/DatagramChannel/Connect.java fails with java.net.BindException: Cannot assign requested address: connect

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 1, 2022
@openjdk openjdk bot closed this Apr 1, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@jerboaa @jmtd Pushed as commit 4c8b099.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants