Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252359: HotSpot Not Identifying it is Running in a Container #986

Closed
wants to merge 1 commit into from

Conversation

jmtd
Copy link

@jmtd jmtd commented Apr 1, 2022

Hi all,

This pull request contains a backport of commit 76f0588a from the openjdk/jdk repository.

The commit being backported was authored by Bob Vandette on 3 Sep 2020 and was reviewed by Severin Gehwolf.

This is part of an effort to backport cgroups v2 support to jdk11u-dev. The patch applies clean and the test passes on my cgroups v2 system.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8252359: HotSpot Not Identifying it is Running in a Container

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/986/head:pull/986
$ git checkout pull/986

Update a local copy of the PR:
$ git checkout pull/986
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/986/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 986

View PR using the GUI difftool:
$ git pr show -t 986

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/986.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2022

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 76f0588aaf265439a589cceb924e3ea9d3fda8f1 8252359: HotSpot Not Identifying it is Running in a Container Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8252359: HotSpot Not Identifying it is Running in a Container

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 1, 2022

Webrevs

@jmtd
Copy link
Author

jmtd commented Apr 1, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@jmtd
Your change (at version fd9f745) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Apr 4, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 4, 2022

Going to push as commit 3cf4e70.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 2f1bee6: 8282887: Potential memory leak in sun.util.locale.provider.HostLocaleProviderAdapterImpl.getNumberPattern() on Windows

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2022
@openjdk openjdk bot closed this Apr 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@jerboaa @jmtd Pushed as commit 3cf4e70.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants