Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist #992

Closed
wants to merge 1 commit into from

Conversation

jmtd
Copy link

@jmtd jmtd commented Apr 4, 2022

This is a backport of JDK-8253435 (Cgroup: 'stomping of mount path' crash if
manually mounted cpusets exist) as part of an effort to backport cgroups v2
support for JDK 11.

It applies clean after the dependent pr/986 (8252359: HotSpot Not Identifying
it is Running in a Container) and the included test passes for me on a pure
cgroups v2 system.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/992/head:pull/992
$ git checkout pull/992

Update a local copy of the PR:
$ git checkout pull/992
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/992/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 992

View PR using the GUI difftool:
$ git pr show -t 992

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/992.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2022

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into pr/986 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0054c15f60cce6470be05d29bfacbdb74cfb7bc9 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Apr 4, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2022

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/986 to master Apr 4, 2022
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout jmtd-backport-76f0588a
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Apr 4, 2022
@jmtd
Copy link
Author

jmtd commented Apr 4, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@jmtd
Your change (at version 4d362ad) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Apr 4, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Apr 4, 2022

Going to push as commit 19ccccc.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 4, 2022
@openjdk openjdk bot closed this Apr 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@jerboaa @jmtd Pushed as commit 19ccccc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants