Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) #994

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Apr 4, 2022

Clean backport part of the cgroups v2 support work.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/994/head:pull/994
$ git checkout pull/994

Update a local copy of the PR:
$ git checkout pull/994
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/994/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 994

View PR using the GUI difftool:
$ git pr show -t 994

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/994.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2bbf8a2a964a64d88298a3dd184459af506e58ed 8245543: Cgroups: Incorrect detection logic on some systems (still reproducible) Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 4, 2022

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8245543: Cgroups: Incorrect detection logic on some systems (still reproducible)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 4, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2022

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Apr 5, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 5, 2022

Going to push as commit 31cbb82.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 7f8a11b: 8280867: Cpuid1Ecx feature parsing is incorrect for AMD CPUs
  • fee03ea: 8275337: C1: assert(false) failed: live_in set of first block must be empty
  • 132c6c4: 8277093: Vector should throw ClassNotFoundException for a missing class of an element
  • a852ad1: 8272358: Some tests may fail when executed with other locales than the US
  • b08aae1: 8272908: Missing coverage for certain classes in com.sun.org.apache.xml.internal.security
  • 708017c: 8272964: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted
  • 1b940f3: 8256146: Cleanup test/jdk/java/nio/channels/DatagramChannel/Connect.java
  • cd591e4: 8254887: C2: assert(cl->trip_count() > 0) failed: peeling a fully unrolled loop
  • aeb7ecf: 8243429: use reproducible random in :vmTestbase_nsk_stress
  • 9bca81b: 8240335: C2: assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/19ccccc9a98fe5819ac9a0583e9b9637dafc5256...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 5, 2022
@openjdk openjdk bot closed this Apr 5, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 5, 2022
@openjdk
Copy link

openjdk bot commented Apr 5, 2022

@jerboaa Pushed as commit 31cbb82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant