-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8218965: aix: support xlclang++ in the compiler detection #995
Conversation
Reviewed-by: ihse, mdoerr Backport Conflicts: - Removed: src/java.desktop/share/native/libfontmanager/harfbuzz/hb-atomic-private.hh (rm in current, updated in backport)
👋 Welcome back backwaterred! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Right, the code using __ibmxl__
was removed with the later upgrade to 2.8.0.
@backwaterred This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 59 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Hello @backwaterred . |
I suggest to apply https://github.com/openjdk/jdk11u-dev/pull/993.diff which should be equivalent to applying all the individual PRs. (They will need rebasing each time because they are not "dependent" PRs). |
Btw. this one is approved and ready for integration if there are no objections. |
Thanks Martin. /integrate |
@backwaterred |
/sponsor |
Going to push as commit 061c083.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr @backwaterred Pushed as commit 061c083. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
#993
Backport of:
8218965: aix: support xlclang++ in the compiler detection
Reviewed-by: ihse, mdoerr
Backport Notes:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/995/head:pull/995
$ git checkout pull/995
Update a local copy of the PR:
$ git checkout pull/995
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/995/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 995
View PR using the GUI difftool:
$ git pr show -t 995
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/995.diff