-
Notifications
You must be signed in to change notification settings - Fork 251
8224214: [AIX] Remove support for legacy xlc compiler #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back backwaterred! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
This one needs rebasing because JDK-8218965 is integrated. |
Reviewed-by: erikj, kbarrett, mdoerr, dholmes Backport Conflicts: - make/autoconf/toolchain.m4: Update header year. - src/hotspot/share/gc/g1/ptrQueue.hpp: Remove procedure definition (cpp does not contian impl). - src/hotspot/share/gc/shared/oopStorage.hpp: Remove procedure definition (cpp does not contain impl). - src/hotspot/share/runtime/vm_version.cpp: Remove ~100 lines not present in base version. - src/hotspot/share/utilities/globalDefinitions_xlc.hpp: Add xlc version check.
3e10d11 to
887b5e1
Compare
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
@backwaterred This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
After some discussion with others, I realized that this would make building with an older version of xlc and using the |
#993
Backport of:
8224214: [AIX] Remove support for legacy xlc compiler
Reviewed-by: erikj, kbarrett, mdoerr, dholmes
Backport Notes:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/996/head:pull/996$ git checkout pull/996Update a local copy of the PR:
$ git checkout pull/996$ git pull https://git.openjdk.java.net/jdk11u-dev pull/996/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 996View PR using the GUI difftool:
$ git pr show -t 996Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/996.diff