8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

[backwaterred]

#993

8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

Reviewed-by: dholmes, goetz, ihse

Backport Notes:

• src/hotspot/share/runtime/arguments.cpp: Remove UNSUPPORTED_OPTION_NULL(AllocateOldGenAt) modified by backport but not present in original source.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/997/head:pull/997
$ git checkout pull/997

Update a local copy of the PR:
$ git checkout pull/997
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/997/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 997

View PR using the GUI difftool:
$ git pr show -t 997

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/997.diff

[bridgekeeper]

👋 Welcome back backwaterred! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (3782d6a0)
• 00: Full (b9061fca)

[GoeLin]

Hi, what's wrong with the Pre-submit tests? Is it caused by your change or by some other, unrelated problem?

Also, please only add the jdk1*u-fix-request if the change is ready to be pushed. Here and in the other changes the review is missing. If you add the label, the change appears in my filter but I will not approve it. It just causes overhead to me.
If you backport a change you think is risky and which might not be approved, you can make an exception and flag it beforehand to bring it to my attention. If so, state so in the comment.

[backwaterred]

please only add the jdk1*u-fix-request if the change is ready to be pushed. Here and in the other changes the review is missing. If you add the label, the change appears in my filter but I will not approve it. It just causes overhead to me.

@GoeLin noted! I have removed the fix-request labels and will re-add when the PRs are reviewed.

[backwaterred]

what's wrong with the Pre-submit tests? Is it caused by your change or by some other, unrelated problem

To your other point, I was not able to reproduce the failure with gcc 9 or gcc 7 on an x86_64 machine running Ubuntu. I believe they are unrelated to this change.

[TheRealMDoerr]

Looks good. This allows us to build OpenJDK 11.0.16 on AIX with updated harfbuzz!

[openjdk]

@backwaterred This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8218136: minor hotspot adjustments for xlclang++ from xlc16 on AIX

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 9b5d972: 8248876: LoadObject with bad base address created for exec file on linux
• 4741ab5: 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions
• 2da50ce: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c
• b9a4153: 8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4
• 811cc9f: 8284573: [11u] ProblemList TestBubbleUpRef.java and TestGCOldWithCMS.java because of 8272195
• e89b698: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test
• 7a02166: 8242312: use reproducible random in hotspot gc tests
• e8fbaad: 8283641: Large value for CompileThresholdScaling causes assert
• aeeab3d: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492
• 5a66c8e: 8283408: Fix a C2 crash when filling arrays with unsafe
• ... and 9 more: https://git.openjdk.java.net/jdk11u-dev/compare/061c08348a4babe66ce1d5481b6c5d34e752c4cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[backwaterred]

/integrate

[openjdk]

@backwaterred
Your change (at version 3782d6a) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit b930441.
Since your change was applied there have been 19 commits pushed to the master branch:

• 9b5d972: 8248876: LoadObject with bad base address created for exec file on linux
• 4741ab5: 8275330: C2: assert(n->is_Root() || n->is_Region() || n->is_Phi() || n->is_MachMerge() || def_block->dominates(block)) failed: uses must be dominated by definitions
• 2da50ce: 8283217: Leak FcObjectSet in getFontConfigLocations() in fontpath.c
• b9a4153: 8284369: TestFailedAllocationBadGraph fails with -XX:TieredStopAtLevel < 4
• 811cc9f: 8284573: [11u] ProblemList TestBubbleUpRef.java and TestGCOldWithCMS.java because of 8272195
• e89b698: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test
• 7a02166: 8242312: use reproducible random in hotspot gc tests
• e8fbaad: 8283641: Large value for CompileThresholdScaling causes assert
• aeeab3d: 8280373: Update Xalan serializer / SystemIDResolver to align with JDK-8270492
• 5a66c8e: 8283408: Fix a C2 crash when filling arrays with unsafe
• ... and 9 more: https://git.openjdk.java.net/jdk11u-dev/compare/061c08348a4babe66ce1d5481b6c5d34e752c4cc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @backwaterred Pushed as commit b930441.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.