Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307779: Relax the java.awt.Robot specification #10

Closed
wants to merge 3 commits into from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Apr 24, 2024

Please review the doc only backport PR of openjdk/jdk#13809.

It is backport of the original commit + build failure fix.

CSR: JDK-8331036


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8307779 needs maintainer approval
  • Change requires CSR request JDK-8331036 to be approved

Issues

  • JDK-8307779: Relax the java.awt.Robot specification (Bug - P3 - Approved)
  • JDK-8331036: Relax the java.awt.Robot specification (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-ri.git pull/10/head:pull/10
$ git checkout pull/10

Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.org/jdk11u-ri.git pull/10/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10

View PR using the GUI difftool:
$ git pr show -t 10

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-ri/pull/10.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 24, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@azvegint This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8307779: Relax the java.awt.Robot specification

Reviewed-by: prr, iris, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c8857c6: 8331145: Update .jcheck/conf and version-numbers for 11.0.0.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Apr 24, 2024
@azvegint
Copy link
Member Author

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

@azvegint has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@azvegint please create a CSR request for issue JDK-8307779 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@mlbridge
Copy link

mlbridge bot commented Apr 24, 2024

Webrevs

@azvegint azvegint changed the title 8307779: Relax the java.awt.Robot specification Backport 21aa057fafd88f4dd677bbf7c99a7eabb6b18409 Apr 24, 2024
@openjdk openjdk bot changed the title Backport 21aa057fafd88f4dd677bbf7c99a7eabb6b18409 8307779: Relax the java.awt.Robot specification Apr 24, 2024
@openjdk
Copy link

openjdk bot commented Apr 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 24, 2024
@openjdk openjdk bot added the approval label Apr 25, 2024
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec and implementation changes as expected for 11.0.0.1.

Associated CSR (JDK-8331036) already Approved.

* @return Color of the pixel
*/
public synchronized Color getPixelColor(int x, int y) {
checkScreenCaptureAllowed();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the addition of this implementation change to comply with the spec will require that we produce an RI for the MR.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches what we have for 17.0.0.1, bar a copyright header context difference and the need to add checkScreenCaptureAllowed()

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval csr Pull request needs approved CSR before integration labels Apr 26, 2024
@azvegint
Copy link
Member Author

azvegint commented May 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 8, 2024

Going to push as commit 42eb684.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c8857c6: 8331145: Update .jcheck/conf and version-numbers for 11.0.0.2

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2024
@openjdk openjdk bot closed this May 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2024
@openjdk
Copy link

openjdk bot commented May 8, 2024

@azvegint Pushed as commit 42eb684.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants