-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8307779: Relax the java.awt.Robot specification #10
Conversation
👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into |
@azvegint This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/csr |
@azvegint has indicated that a compatibility and specification (CSR) request is needed for this pull request. @azvegint please create a CSR request for issue JDK-8307779 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
Webrevs
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec and implementation changes as expected for 11.0.0.1.
Associated CSR (JDK-8331036) already Approved.
* @return Color of the pixel | ||
*/ | ||
public synchronized Color getPixelColor(int x, int y) { | ||
checkScreenCaptureAllowed(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the addition of this implementation change to comply with the spec will require that we produce an RI for the MR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Matches what we have for 17.0.0.1, bar a copyright header context difference and the need to add checkScreenCaptureAllowed()
/integrate |
Please review the doc only backport PR of openjdk/jdk#13809.
It is backport of the original commit + build failure fix.
CSR: JDK-8331036
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-ri.git pull/10/head:pull/10
$ git checkout pull/10
Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.org/jdk11u-ri.git pull/10/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10
View PR using the GUI difftool:
$ git pr show -t 10
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-ri/pull/10.diff
Webrev
Link to Webrev Comment