-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8305682: Update the javadoc in the Character class to state support for GB 18030-2022 Implementation Level 2 #8
Conversation
…or GB 18030-2022 Implementation Level 2
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
@naotoj This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/integrate |
Going to push as commit 9269109. |
This is to support GB18030-2022 "Implementation Level 2", an extension to JDK-8301401. Although all the required code points for Implementation Level 2 are included in JDK 11, the javadoc in the Character class needs to be changed.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-ri.git pull/8/head:pull/8
$ git checkout pull/8
Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.org/jdk11u-ri.git pull/8/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 8
View PR using the GUI difftool:
$ git pr show -t 8
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-ri/pull/8.diff
Webrev
Link to Webrev Comment