-
Notifications
You must be signed in to change notification settings - Fork 193
8352097: (tz) zone.tab update missed in 2025a backport #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back andrew! A progress list of the required criteria for merging this PR into |
@gnu-andrew This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Follow-up fix to the tzdata 2025a backport to include a change to a file no longer present in OpenJDK 25, but patched in OpenJDK 24. Tests on |
@gnu-andrew |
/integrate |
Going to push as commit 13dab16. |
@gnu-andrew Pushed as commit 13dab16. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
As with openjdk/jdk21u#460 & openjdk/jdk17u#405, the 11u backport of the tzdata 2025a update missed an update to zone.tab, as this was not present in the 25u commit on which it was originally based, due to its removal in JDK-8166983. The change was in the 24u commit which was applied later than the 21u one.
We should add this missing change to the existing 2025a update in 11.0.27 and consider backporting JDK-8166983 for 11.0.28 (now proposed for 24 in openjdk/jdk24u#150).
Backport from 17u is clean. Tests pass:
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/101/head:pull/101
$ git checkout pull/101
Update a local copy of the PR:
$ git checkout pull/101
$ git pull https://git.openjdk.org/jdk11u.git pull/101/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 101
View PR using the GUI difftool:
$ git pr show -t 101
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/101.diff
Using Webrev
Link to Webrev Comment