-
Notifications
You must be signed in to change notification settings - Fork 201
8368308: ISO 4217 Amendment 180 Update #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Currency tests pass with this: |
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
|
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
gnu-andrew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just backported this myself and it was clean for me too :)
|
|
|
/approval request Please allow this backport in for JDK 11.0.29 (October) since it includes currency updates which are going to be in effect before the next update in January 2026. Those amendment updates are usually low risk. Currency tests pass and patch is reviewed by Andrew Hughes. |
|
/approve yes |
|
@gnu-andrew |
|
/integrate |
|
Going to push as commit 2abaf35. |
Clean backport from the JDK 17u version of this.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u.git pull/106/head:pull/106$ git checkout pull/106Update a local copy of the PR:
$ git checkout pull/106$ git pull https://git.openjdk.org/jdk11u.git pull/106/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 106View PR using the GUI difftool:
$ git pr show -t 106Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/106.diff
Using Webrev
Link to Webrev Comment