-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8276774: Cookie stored in CookieHandler not sent if user headers contain cookie #18
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This backport looks correct to me. Thanks for doing it!
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the reviews! |
/integrate |
Going to push as commit 8fe5d59. |
@TheRealMDoerr Pushed as commit 8fe5d59. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Almost clean Backport of JDK-8276774. One hunk in Stream.java required manual integration because the switch expression doesn't exist in 11u. The test needed adaptations because SimpleSSLContext is located at a different place in 11u and
Stream.toList()
is unavailable (see 2nd commit).Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u pull/18/head:pull/18
$ git checkout pull/18
Update a local copy of the PR:
$ git checkout pull/18
$ git pull https://git.openjdk.java.net/jdk11u pull/18/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 18
View PR using the GUI difftool:
$ git pr show -t 18
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u/pull/18.diff