-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 #31
8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 #31
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
1fa5b7d
to
d2d8ef3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, https://bugs.openjdk.java.net/browse/JDK-8263191 is not in 11u.
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Thanks for the review! We'll test it one more night before requesting jdk11u-critical approval. |
Thanks for the review! Nightly tests have passed. I've requested jdk11u-critical approval. |
/integrate |
Going to push as commit 3a0074c. |
@TheRealMDoerr Pushed as commit 3a0074c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Restore usage of ThreadInVMfromJavaNoAsyncException in JRT_ENTRY_NO_ASYNC. See JBS for details.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u pull/31/head:pull/31
$ git checkout pull/31
Update a local copy of the PR:
$ git checkout pull/31
$ git pull https://git.openjdk.java.net/jdk11u pull/31/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 31
View PR using the GUI difftool:
$ git pr show -t 31
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u/pull/31.diff