Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795 #31

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 16, 2022

Restore usage of ThreadInVMfromJavaNoAsyncException in JRT_ENTRY_NO_ASYNC. See JBS for details.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u pull/31/head:pull/31
$ git checkout pull/31

Update a local copy of the PR:
$ git checkout pull/31
$ git pull https://git.openjdk.java.net/jdk11u pull/31/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 31

View PR using the GUI difftool:
$ git pr show -t 31

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u/pull/31.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 16, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@TheRealMDoerr TheRealMDoerr force-pushed the 8283270_11u_fix_JRT_ENTRY_NO_ASYNC_after_8253795 branch from 1fa5b7d to d2d8ef3 Compare March 16, 2022 16:01
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 16, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 16, 2022

Webrevs

Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openjdk
Copy link

openjdk bot commented Mar 16, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283270: [11u] broken JRT_ENTRY_NO_ASYNC after Backport of JDK-8253795

Reviewed-by: sgehwolf, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 16, 2022
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review! We'll test it one more night before requesting jdk11u-critical approval.

@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review! Nightly tests have passed. I've requested jdk11u-critical approval.

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 17, 2022

Going to push as commit 3a0074c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 17, 2022
@openjdk openjdk bot closed this Mar 17, 2022
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Mar 17, 2022
@TheRealMDoerr TheRealMDoerr deleted the 8283270_11u_fix_JRT_ENTRY_NO_ASYNC_after_8253795 branch March 17, 2022 09:36
@openjdk openjdk bot removed the rfr Pull request is ready for review label Mar 17, 2022
@openjdk
Copy link

openjdk bot commented Mar 17, 2022

@TheRealMDoerr Pushed as commit 3a0074c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants