-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8282761: XPathFactoryImpl remove setProperty and getProperty methods #32
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pre-submit failures: missing dependencies, fixed in jdk11u-dev. |
/integrate |
Going to push as commit 9a7bd43. |
I backport this for parity with 11.0.15-oracle.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u pull/32/head:pull/32
$ git checkout pull/32
Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.java.net/jdk11u pull/32/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32
View PR using the GUI difftool:
$ git pr show -t 32
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u/pull/32.diff