Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8286444: javac errors after JDK-8251329 are not helpful enough to find root cause #37

Closed
wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 1, 2022

Backport of JDK-8286444. Change did not apply cleanly but only copyright header needed resolving.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8286444: javac errors after JDK-8251329 are not helpful enough to find root cause

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u pull/37/head:pull/37
$ git checkout pull/37

Update a local copy of the PR:
$ git checkout pull/37
$ git pull https://git.openjdk.java.net/jdk11u pull/37/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 37

View PR using the GUI difftool:
$ git pr show -t 37

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u/pull/37.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 1, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 29c4b8e80d1860249a79cfd1941354150468fc5b 8286444: javac errors after JDK-8251329 are not helpful enough to find root cause Jun 1, 2022
@openjdk
Copy link

openjdk bot commented Jun 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 1, 2022
@RealCLanger
Copy link
Contributor Author

/clean

@openjdk openjdk bot added rfr Pull request is ready for review clean labels Jun 1, 2022
@openjdk
Copy link

openjdk bot commented Jun 1, 2022

@RealCLanger This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 1, 2022

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8286444: javac errors after JDK-8251329 are not helpful enough to find root cause

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 1, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 1, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

GHA failures unrelated.
Linux x86: gc/metaspace/TestMetaspacePerfCounters.java#id3 - intermittent
Windows: runtime/Thread/SuspendAtExit.java - intermittent
Windows: tools/javac/Paths/MineField.sh - Will be fixed with #39
Windows: tools/javac/Paths/wcMineField.sh - Will be fixed with #39

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 3, 2022

Going to push as commit 3f9d731.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 54a1784: 8287378: GHA: Update cygwin to fix issues in langtools tests on Windows
  • 3625ce7: 8287739: [11u] ProblemList sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java
  • 4546db6: 8240132: ProblemList com/sun/jdi/InvokeHangTest.java
  • 06ead4e: 8274171: java/nio/file/Files/probeContentType/Basic.java failed on "Content type" mismatches

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2022
@openjdk openjdk bot closed this Jun 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 3, 2022
@openjdk
Copy link

openjdk bot commented Jun 3, 2022

@RealCLanger Pushed as commit 3f9d731.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-29c4b8e8 branch June 3, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant