New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8286594: (zipfs) Mention paths with dot elements in ZipException and cleanups #38
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, the hunk is omitted, because JDK-8222276 and JDK-8213031 are not in 11u.
I noticed that you are also backporting JDK-8286444 and JDK-8286855.
Makes sense.
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
GHA failures on Windows are unrelated, Will be fixed with #39 |
/integrate |
Going to push as commit 9c64a06.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 9c64a06. |
The backport needed some resolving/adaptation to older zipfs code.
Method IndexNode:toString is not implemented, so this part of the upstream patch does not apply.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u pull/38/head:pull/38
$ git checkout pull/38
Update a local copy of the PR:
$ git checkout pull/38
$ git pull https://git.openjdk.java.net/jdk11u pull/38/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 38
View PR using the GUI difftool:
$ git pr show -t 38
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u/pull/38.diff