Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 #46

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 9, 2022

I backport this for parity with 11.0.16-oracle.

I had to resolve DatagramChannelImpl.c because 11 has Solaris specific code in the context.
The test has a different @test description.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u pull/46/head:pull/46
$ git checkout pull/46

Update a local copy of the PR:
$ git checkout pull/46
$ git pull https://git.openjdk.org/jdk11u pull/46/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 46

View PR using the GUI difftool:
$ git pr show -t 46

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u/pull/46.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 269eae61894b6bd0a7512045a369b53df747f6e5 8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4 Jun 9, 2022
@openjdk
Copy link

openjdk bot commented Jun 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Jun 9, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 9, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 10, 2022

Pre-submit failure: TestMetaspacePerfCounters.java#id3 known to be failing, unrelated.

Copy link
Contributor

@RealCLanger RealCLanger left a comment

LGTM

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8285515: (dc) DatagramChannel.disconnect fails with "Invalid argument" on macOS 12.4

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 10, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Jun 10, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 10, 2022

Going to push as commit c64f12c.

@openjdk openjdk bot added the integrated label Jun 10, 2022
@openjdk openjdk bot closed this Jun 10, 2022
@openjdk openjdk bot removed ready rfr labels Jun 10, 2022
@openjdk
Copy link

openjdk bot commented Jun 10, 2022

@GoeLin Pushed as commit c64f12c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8285515 branch Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants